-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for failed parse log with invalid git version
#10801
Conversation
Do I need to add a changelog for this, I am not sure since this is a very much internal change, causing no changes? Also, I can't seem to figure out why the docs CI is failing. |
I think this doesn't need any changelog entries. :) |
#10814 will fix the docs failure. Once that is merged, you'd likely need to rebase this PR. If you aren't familiar with rebasing PRs, you might find this article to be a helpful reference to have! |
Ok cool, yeah I am familiar with rebasing 👍🏻. |
Hey @pradyunsg could you take another look at this PR? |
Looks like #10906 is fixing the docs check failure. Will rebase when it gets merged 👍🏻 |
Could you rebase this? The CI issue got addressed in #10912. |
Thanks @Shivansh-007! ^>^ Do you want to try improving an error message when reading an improper METADATA file or improving the documentation for one of our CLI options? |
I am currently on break (not actually working on any code) with term-end exams, I can give 10839 a shot once I get back :) |
Awesome! All the best for your exams! ^.^ |
Closes #10361
When running the linter, it removed the Unicode string prefix for some reason, not sure about that change.