Improve presentation of errors from subprocesses, during installation #10795
Commits on Jan 25, 2022
-
Require every
call_subprocesscall-site to passcommand_descThis serves as additional context that can be presented in error messages.
-
Modernise the shim, to account for the Python 3.2+ support matrix. This also presents clearer error messages on failures, the included comment helps inform users about why this shim exists and the traceback now explicitly mentions `<pip-setuptools-shim>` to make it clearer to users that this shim exists.
-
Use
logger.warninginstead ofwarnings.warnThis is more in line with the rest of our output presentation logic.
-
Clearly document that exceptions shouldn't import any internals
This file should be importable in all other modules, which means it can't be importing any of those modules (to prevent an import loop).
-
Improve presentation of
LegacyInstallFailureThese errors now more clearly note where the error occurred and what component is at fault.
-
Add diagnostics to
InstallationSubprocessErrorThis more clearly states where the error came from, presents it in a more approachable format with context provided for what this error is related to.
-
-
-
-
Prettify messages for discarding candidates due to issues
These are more pleasing colours and, more importantly, a clearer presentation style of the package vs the error.
-
-
Tweak the chattymodule to not leak potentially information
I'd like to use this in screenshots, but the os.environ makes it a bit tricky to do.
-
-
-
Double-escape paths on Windows
This helps ensure that they aren't improperly handled due to the newer string-in-string design for the setuptools invocation script.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.