Remove direct pkg_resources usages in req_install and req_uninstall #10390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
This also by extension converts req_uninstall since the two are very much coupled together.
uranusjr
force-pushed
the
metadata-210823
branch
from
f8a3f73 to
033576f
Compare
|
Looks like we’ll step on each other’s changes quite a lot. Is #10249 finished now? I’ll take a look and maybe get it merged first so I can build on it directly. |
github-actions
bot
added
the
needs rebase or merge
|
Superceded by #10511. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two are very much coupled together.
Actually not much left after this patch! There are still quite some lingering
pkg_resourceusages, but those are calling things likesafe_extrayield_linesetc. that should either be implemented in pip or included inpackaging. But this one is probably going to take a while, everything is hairy whenInstallRequirementis involved.