Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect "the other" Red Hat patch for Cygwin #10250

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

uranusjr
Copy link
Member

Another one for #10151 and #10208. This should cover Cygwin users and also provide slightly better detection for Red Hat derivatives, as discussed in #10217.

cc @allenatdecisiv

@uranusjr uranusjr added this to the 21.2.3 milestone Jul 31, 2021
@allenatdecisiv
Copy link

@uranusjr,

I created a Cygwin package with the patch from this PR, here's the source: https://github.com/allenatdecisiv/python-pip-21.2.2-1025.src.

It passed a basic uninstall and re-install of platformdirs. Is there any other testing I could do?

$ cygcheck -c | grep ^python38-pip
python38-pip                  21.2.2-1025                     OK

$ set | grep PIP_
PIP_FORMAT=columns
PIP_NO_COLOR=true

$ command -V pip
pip is hashed (/usr/bin/pip)

$ pip --version
pip 21.2.2.1025 from /usr/lib/python3.8/site-packages/pip (python 3.8)

$ pip uninstall platformdirs
Found existing installation: platformdirs 2.2.0
Uninstalling platformdirs-2.2.0:
  Would remove:
    /usr/local/lib/python3.8/site-packages/platformdirs-2.2.0.dist-info/*
    /usr/local/lib/python3.8/site-packages/platformdirs/*
Proceed (Y/n)? Y
  Successfully uninstalled platformdirs-2.2.0

$ pip install platformdirs
Collecting platformdirs
  Using cached platformdirs-2.2.0-py3-none-any.whl (13 kB)
Installing collected packages: platformdirs
Successfully installed platformdirs-2.2.0

@uranusjr
Copy link
Member Author

uranusjr commented Aug 2, 2021

I think what you did is enough (for this patch), thanks a ton!

@uranusjr uranusjr merged commit a31c30f into pypa:main Aug 6, 2021
@uranusjr uranusjr deleted the locations-red-hat-prefix branch August 6, 2021 09:55
@uranusjr uranusjr mentioned this pull request Aug 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants