Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored six to 1.16.0 #10044

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Update vendored six to 1.16.0 #10044

merged 2 commits into from
Jun 7, 2021

Conversation

domdfcoding
Copy link
Contributor

Update vendored six to 1.16.0 and urllib3 to 1.26.5

Fixes #10043

I've never updated the vendored deps before so I hope I've done this right 🤞.

@uranusjr
Copy link
Member

uranusjr commented Jun 7, 2021

How did you update them? If you just run the vendoring script, everything should automatically work if it didn’t generate any errors (and the tests pass).

@domdfcoding
Copy link
Contributor Author

How did you update them? If you just run the vendoring script, everything should automatically work if it didn’t generate any errors (and the tests pass).

That's what I did. Grand.

@domdfcoding domdfcoding marked this pull request as ready for review June 7, 2021 17:47
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@pradyunsg pradyunsg merged commit 776238a into pypa:main Jun 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
@domdfcoding domdfcoding deleted the update-six branch September 8, 2022 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings emitted by vendored six versions
3 participants