Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test isolation for venv #7356

Open
pradyunsg opened this issue Nov 15, 2019 · 4 comments
Open

Fix test isolation for venv #7356

pradyunsg opened this issue Nov 15, 2019 · 4 comments
Labels
C: tests Testing and related things project: virtualenv Related to virtualenv type: bug A confirmed bug or unintended behavior type: maintenance Related to Development and Maintenance Processes

Comments

@pradyunsg
Copy link
Member

pradyunsg commented Nov 15, 2019

Description

The test isolation logic should be fixed to work for venv. Once such a fix is made, this commit (8981895) should be reverted.

Expected behavior

Tests get isolated properly and correctly handle venv-based environments.

@pradyunsg pradyunsg added type: bug A confirmed bug or unintended behavior C: tests Testing and related things type: maintenance Related to Development and Maintenance Processes project: virtualenv Related to virtualenv labels Nov 15, 2019
@kritika12298
Copy link

Hello, I am Kritika Gupta and I would like to contribute to this issue

@pradyunsg
Copy link
Member Author

Hi @kritika12298!

This is an extremely involved and complicated issue that'll require building an understanding of how venv environments work, how pip's test suite fixtures are set up and how pip's venv test setup works - and why it might be broken.

If you've not contributed to pip before, I suggest you try tackling a different issue. Let me know if you'd like me to suggest an issue to you. :)

@kritika12298
Copy link

kritika12298 commented Mar 7, 2020 via email

@ssurbhi560
Copy link
Contributor

Hey @pradyunsg ! I was trying to go through this issue but there is no much discussion over this, so I am having quite trouble in understanding this. Can you please give some context about the problem or any plausible solution that you might have. That'd be a great help. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: tests Testing and related things project: virtualenv Related to virtualenv type: bug A confirmed bug or unintended behavior type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

3 participants