Checking out Bazaar branch makes full clone #5444

jelmer · 2018-05-26T18:34:00Z

When checking out a Bazaar branch, pip currently makes a full clone of the branch history. This is unnecessary and much slower than just fetching the latest revision:

For example, performance on my system for 'bzr co --lightweight lp:bzr':

0.60s user 0.11s system 5% cpu 12.234 total

Performance on my system for 'bzr branch lp:bzr':

65.41s user 1.48s system 39% cpu 2:47.91 total

* Use lightweight checkouts rather than a full branch clone * Export directly from the remote branch Fixes pypa#5444, pypa#5443

Fixes pypa#5444

pradyunsg · 2022-10-07T15:09:54Z

@jelmer Thanks for filing #11264!

Could I request you to remove the reference to this issue from the commit message? It causes significant spam on the issue (as you can see here) since it creates a new event every time you amend/rebase the commit.

jelmer · 2022-10-07T17:12:12Z

@pradyunsg I'm not happy about rebasing it regularly either :-) I'd argue that the problem is really that nobody (besides a yearly drive-by comment here or there) has properly reviewed the PR since it was initially opened more than 4 years ago. :-/

It looks like there is nobody on the pypa team with the expertise to review bzr-related PRs, and that's a chicken-egg type problem. What can I do to further bzr support in pip if there is nobody to review my PRs?

pradyunsg · 2022-10-07T17:34:18Z

Yea... I don't think any of the maintainers uses bzr themselves, so don't really have first-hand experience or expertise -- I'd be happy to be wrong tho.

What can I do to further bzr support in pip if there is nobody to review my PRs?

Well, I don't have a good answer here. :/

If it were another part of the codebase, I would've suggested that you mention me after rebasing this PR on the current main -- but the vcs bits of the codebase are already parts I'm not particularly familiar with, and bzr even less so.

pfmoore · 2022-10-07T17:56:43Z

@sbidoul commented on the PR previously. But unless he has reservations, I'm frankly inclined to say let's just merge #11264, on the basis that I don't think we have many people using bzr support, so the risk of causing harm to anyone is relatively low.

If there's a major issue, then hopefully @jelmer will be able to provide a fix, but if not we can simply revert the PR.

jelmer · 2022-10-07T20:58:27Z

Thanks, @pfmoore & @pradyunsg !

Bumps [pip](https://github.com/pypa/pip) from 22.2.2 to 22.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>22.3 (2022-10-15)</h1> <h2>Deprecations and Removals</h2> <ul> <li>Deprecate <code>--install-options</code> which forces pip to use the deprecated <code>install</code> command of <code>setuptools</code>. (<code>[#11358](pypa/pip#11358) <https://github.com/pypa/pip/issues/11358></code>_)</li> <li>Deprecate installation with 'setup.py install' when no-binary is enabled for source distributions without 'pyproject.toml'. (<code>[#11452](pypa/pip#11452) <https://github.com/pypa/pip/issues/11452></code>_)</li> <li>Deprecate ```--no-binary`` disabling the wheel cache. (<code>[#11454](pypa/pip#11454) <https://github.com/pypa/pip/issues/11454></code>_)</li> <li>Remove <code>--use-feature=2020-resolver</code> opt-in flag. This was supposed to be removed in 21.0, but missed during that release cycle. (<code>[#11493](pypa/pip#11493) <https://github.com/pypa/pip/issues/11493></code>_)</li> <li>Deprecate installation with 'setup.py install' when the 'wheel' package is absent for source distributions without 'pyproject.toml'. (<code>[#8559](pypa/pip#8559) <https://github.com/pypa/pip/issues/8559></code>_)</li> <li>Remove the ability to use <code>pip list --outdated</code> in combination with <code>--format=freeze</code>. (<code>[#9789](pypa/pip#9789) <https://github.com/pypa/pip/issues/9789></code>_)</li> </ul> <h2>Features</h2> <ul> <li>Use <code>shell=True</code> for opening the editor with <code>pip config edit</code>. (<code>[#10716](pypa/pip#10716) <https://github.com/pypa/pip/issues/10716></code>_)</li> <li>Use the <code>data-dist-info-metadata</code> attribute from :pep:<code>658</code> to resolve distribution metadata without downloading the dist yet. (<code>[#11111](pypa/pip#11111) <https://github.com/pypa/pip/issues/11111></code>_)</li> <li>Add an option to run the test suite with pip built as a zipapp. (<code>[#11250](pypa/pip#11250) <https://github.com/pypa/pip/issues/11250></code>_)</li> <li>Add a <code>--python</code> option to allow pip to manage Python environments other than the one pip is installed in. (<code>[#11320](pypa/pip#11320) <https://github.com/pypa/pip/issues/11320></code>_)</li> <li>Document the new (experimental) zipapp distribution of pip. (<code>[#11459](pypa/pip#11459) <https://github.com/pypa/pip/issues/11459></code>_)</li> <li>Use the much faster 'bzr co --lightweight' to obtain a copy of a Bazaar tree. (<code>[#5444](pypa/pip#5444) <https://github.com/pypa/pip/issues/5444></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Fix <code>--no-index</code> when <code>--index-url</code> or <code>--extra-index-url</code> is specified inside a requirements file. (<code>[#11276](pypa/pip#11276) <https://github.com/pypa/pip/issues/11276></code>_)</li> <li>Ensure that the candidate <code>pip</code> executable exists, when checking for a new version of pip. (<code>[#11309](pypa/pip#11309) <https://github.com/pypa/pip/issues/11309></code>_)</li> <li>Ignore distributions with invalid <code>Name</code> in metadata instead of crashing, when using the <code>importlib.metadata</code> backend. (<code>[#11352](pypa/pip#11352) <https://github.com/pypa/pip/issues/11352></code>_)</li> <li>Raise RequirementsFileParseError when parsing malformed requirements options that can't be sucessfully parsed by shlex. (<code>[#11491](pypa/pip#11491) <https://github.com/pypa/pip/issues/11491></code>_)</li> <li>Fix build environment isolation on some system Pythons. (<code>[#6264](pypa/pip#6264) <https://github.com/pypa/pip/issues/6264></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade certifi to 2022.9.24</li> <li>Upgrade distlib to 0.3.6</li> <li>Upgrade idna to 3.4</li> <li>Upgrade pep517 to 0.13.0</li> <li>Upgrade pygments to 2.13.0</li> <li>Upgrade tenacity to 8.1.0</li> <li>Upgrade typing_extensions to 4.4.0</li> <li>Upgrade urllib3 to 1.26.12</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/0a76da3a94130fad58b086e331c3d3e1b02a89eb"><code>0a76da3</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/25638287f8b8bd571a10c4f5ae1b7f4eae454dcc"><code>2563828</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/e86f27fe4ee3fe45fc0fcd2372f71d39d1d013c1"><code>e86f27f</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11493">#11493</a> from pradyunsg/remove-2020-resolver-opt-in</li> <li><a href="https://github.com/pypa/pip/commit/1fcc3ce4b531ac6bc80c1d102d4ef9610074e195"><code>1fcc3ce</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11514">#11514</a> from pradyunsg/certifi-update</li> <li><a href="https://github.com/pypa/pip/commit/65c23fa99d19af8ebd375e7129213794dce4b4b2"><code>65c23fa</code></a> Unnormalise the certifi version</li> <li><a href="https://github.com/pypa/pip/commit/739158cc80f138dbed9e426f3408811acef2d993"><code>739158c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11516">#11516</a> from pradyunsg/check-manifest</li> <li><a href="https://github.com/pypa/pip/commit/4e48bbc31cf34b1b4ccd100a787d1204ddb8866b"><code>4e48bbc</code></a> Move check-manifest to a CI check</li> <li><a href="https://github.com/pypa/pip/commit/1b7e5ef34f926f33fa7932239229220dd65eb7a6"><code>1b7e5ef</code></a> Upgrade certifi to 2022.9.24</li> <li><a href="https://github.com/pypa/pip/commit/2a0552ac61ee26df04e08e21943a1e36aa880db1"><code>2a0552a</code></a> Replace complex certifi patch with a more targetted requests patch</li> <li><a href="https://github.com/pypa/pip/commit/eb906997da97bbbd1f74127297d7ce9a54a6a2a0"><code>eb90699</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11502">#11502</a> from pradyunsg/vendoring-updates</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/22.2.2...22.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=22.2.2&new-version=22.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

…s/@jsii/python-runtime (#3803) Updates the requirements on [pip](https://github.com/pypa/pip) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>22.3 (2022-10-15)</h1> <h2>Deprecations and Removals</h2> <ul> <li>Deprecate <code>--install-options</code> which forces pip to use the deprecated <code>install</code> command of <code>setuptools</code>. (<code>[#11358](pypa/pip#11358) <https://github.com/pypa/pip/issues/11358></code>_)</li> <li>Deprecate installation with 'setup.py install' when no-binary is enabled for source distributions without 'pyproject.toml'. (<code>[#11452](pypa/pip#11452) <https://github.com/pypa/pip/issues/11452></code>_)</li> <li>Deprecate ```--no-binary`` disabling the wheel cache. (<code>[#11454](pypa/pip#11454) <https://github.com/pypa/pip/issues/11454></code>_)</li> <li>Remove <code>--use-feature=2020-resolver</code> opt-in flag. This was supposed to be removed in 21.0, but missed during that release cycle. (<code>[#11493](pypa/pip#11493) <https://github.com/pypa/pip/issues/11493></code>_)</li> <li>Deprecate installation with 'setup.py install' when the 'wheel' package is absent for source distributions without 'pyproject.toml'. (<code>[#8559](pypa/pip#8559) <https://github.com/pypa/pip/issues/8559></code>_)</li> <li>Remove the ability to use <code>pip list --outdated</code> in combination with <code>--format=freeze</code>. (<code>[#9789](pypa/pip#9789) <https://github.com/pypa/pip/issues/9789></code>_)</li> </ul> <h2>Features</h2> <ul> <li>Use <code>shell=True</code> for opening the editor with <code>pip config edit</code>. (<code>[#10716](pypa/pip#10716) <https://github.com/pypa/pip/issues/10716></code>_)</li> <li>Use the <code>data-dist-info-metadata</code> attribute from :pep:<code>658</code> to resolve distribution metadata without downloading the dist yet. (<code>[#11111](pypa/pip#11111) <https://github.com/pypa/pip/issues/11111></code>_)</li> <li>Add an option to run the test suite with pip built as a zipapp. (<code>[#11250](pypa/pip#11250) <https://github.com/pypa/pip/issues/11250></code>_)</li> <li>Add a <code>--python</code> option to allow pip to manage Python environments other than the one pip is installed in. (<code>[#11320](pypa/pip#11320) <https://github.com/pypa/pip/issues/11320></code>_)</li> <li>Document the new (experimental) zipapp distribution of pip. (<code>[#11459](pypa/pip#11459) <https://github.com/pypa/pip/issues/11459></code>_)</li> <li>Use the much faster 'bzr co --lightweight' to obtain a copy of a Bazaar tree. (<code>[#5444](pypa/pip#5444) <https://github.com/pypa/pip/issues/5444></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Fix <code>--no-index</code> when <code>--index-url</code> or <code>--extra-index-url</code> is specified inside a requirements file. (<code>[#11276](pypa/pip#11276) <https://github.com/pypa/pip/issues/11276></code>_)</li> <li>Ensure that the candidate <code>pip</code> executable exists, when checking for a new version of pip. (<code>[#11309](pypa/pip#11309) <https://github.com/pypa/pip/issues/11309></code>_)</li> <li>Ignore distributions with invalid <code>Name</code> in metadata instead of crashing, when using the <code>importlib.metadata</code> backend. (<code>[#11352](pypa/pip#11352) <https://github.com/pypa/pip/issues/11352></code>_)</li> <li>Raise RequirementsFileParseError when parsing malformed requirements options that can't be sucessfully parsed by shlex. (<code>[#11491](pypa/pip#11491) <https://github.com/pypa/pip/issues/11491></code>_)</li> <li>Fix build environment isolation on some system Pythons. (<code>[#6264](pypa/pip#6264) <https://github.com/pypa/pip/issues/6264></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade certifi to 2022.9.24</li> <li>Upgrade distlib to 0.3.6</li> <li>Upgrade idna to 3.4</li> <li>Upgrade pep517 to 0.13.0</li> <li>Upgrade pygments to 2.13.0</li> <li>Upgrade tenacity to 8.1.0</li> <li>Upgrade typing_extensions to 4.4.0</li> <li>Upgrade urllib3 to 1.26.12</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/0a76da3a94130fad58b086e331c3d3e1b02a89eb"><code>0a76da3</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/25638287f8b8bd571a10c4f5ae1b7f4eae454dcc"><code>2563828</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/e86f27fe4ee3fe45fc0fcd2372f71d39d1d013c1"><code>e86f27f</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11493">#11493</a> from pradyunsg/remove-2020-resolver-opt-in</li> <li><a href="https://github.com/pypa/pip/commit/1fcc3ce4b531ac6bc80c1d102d4ef9610074e195"><code>1fcc3ce</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11514">#11514</a> from pradyunsg/certifi-update</li> <li><a href="https://github.com/pypa/pip/commit/65c23fa99d19af8ebd375e7129213794dce4b4b2"><code>65c23fa</code></a> Unnormalise the certifi version</li> <li><a href="https://github.com/pypa/pip/commit/739158cc80f138dbed9e426f3408811acef2d993"><code>739158c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11516">#11516</a> from pradyunsg/check-manifest</li> <li><a href="https://github.com/pypa/pip/commit/4e48bbc31cf34b1b4ccd100a787d1204ddb8866b"><code>4e48bbc</code></a> Move check-manifest to a CI check</li> <li><a href="https://github.com/pypa/pip/commit/1b7e5ef34f926f33fa7932239229220dd65eb7a6"><code>1b7e5ef</code></a> Upgrade certifi to 2022.9.24</li> <li><a href="https://github.com/pypa/pip/commit/2a0552ac61ee26df04e08e21943a1e36aa880db1"><code>2a0552a</code></a> Replace complex certifi patch with a more targetted requests patch</li> <li><a href="https://github.com/pypa/pip/commit/eb906997da97bbbd1f74127297d7ce9a54a6a2a0"><code>eb90699</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/11502">#11502</a> from pradyunsg/vendoring-updates</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/22.2...22.3">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

pradyunsg added the S: needs triage Issues/PRs that need to be triaged label May 31, 2018

jelmer mentioned this issue Jun 23, 2018

Improve performance of the Bazaar VCS backend #5445

Closed

cjerdonek changed the title ~~Creates full clone of Bazaar branch when obtaining remote history~~ Checking out Bazaar branch makes full clone Aug 18, 2018

cjerdonek added type: enhancement Improvements to functionality C: vcs pip's interaction with version control systems like git, svn and bzr and removed S: needs triage Issues/PRs that need to be triaged labels Aug 18, 2018

jelmer added a commit to jelmer/pip that referenced this issue Sep 27, 2018

Some performance improvements for Bazaar:

026ab4d

* Use lightweight checkouts rather than a full branch clone * Export directly from the remote branch Fixes pypa#5444, pypa#5443

jelmer added a commit to jelmer/pip that referenced this issue Jan 15, 2019

bazaar: Use lightweight checkouts rather than a full branch clone

862178c

Fixes pypa#5444

jelmer mentioned this issue Jul 15, 2022

bazaar: Use lightweight checkouts rather than a full branch clone #11264

Merged

jelmer added a commit to jelmer/pip that referenced this issue Jul 15, 2022

bazaar: Use lightweight checkouts rather than a full branch clone

a88ec53

Fixes pypa#5444

jelmer added a commit to jelmer/pip that referenced this issue Aug 17, 2022

bazaar: Use lightweight checkouts rather than a full branch clone

67d2fe6

Fixes pypa#5444

jelmer added a commit to jelmer/pip that referenced this issue Sep 4, 2022

bazaar: Use lightweight checkouts rather than a full branch clone

4241bc8

Fixes pypa#5444

jelmer added a commit to jelmer/pip that referenced this issue Sep 4, 2022

bazaar: Use lightweight checkouts rather than a full branch clone

fc9779b

Fixes pypa#5444

jelmer added a commit to jelmer/pip that referenced this issue Sep 4, 2022

bazaar: Use lightweight checkouts rather than a full branch clone

cca101d

Fixes pypa#5444

jelmer added a commit to jelmer/pip that referenced this issue Sep 4, 2022

bazaar: Use lightweight checkouts rather than a full branch clone

7380239

Fixes pypa#5444

pradyunsg closed this as completed in #11264 Oct 7, 2022

github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checking out Bazaar branch makes full clone #5444

Checking out Bazaar branch makes full clone #5444

jelmer commented May 26, 2018

pradyunsg commented Oct 7, 2022 •

edited

Loading

jelmer commented Oct 7, 2022

pradyunsg commented Oct 7, 2022

pfmoore commented Oct 7, 2022

jelmer commented Oct 7, 2022

Checking out Bazaar branch makes full clone #5444

Checking out Bazaar branch makes full clone #5444

Comments

jelmer commented May 26, 2018

pradyunsg commented Oct 7, 2022 • edited Loading

jelmer commented Oct 7, 2022

pradyunsg commented Oct 7, 2022

pfmoore commented Oct 7, 2022

jelmer commented Oct 7, 2022

pradyunsg commented Oct 7, 2022 •

edited

Loading