Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --global-option to egg_info command too #4383

Open
fabio-t opened this issue Mar 27, 2017 · 4 comments
Open

Add --global-option to egg_info command too #4383

fabio-t opened this issue Mar 27, 2017 · 4 comments
Labels
C: PEP 517 impact Affected by PEP 517 processing state: awaiting PR Feature discussed, PR is needed type: enhancement Improvements to functionality

Comments

@fabio-t
Copy link

fabio-t commented Mar 27, 2017

  • Pip version: 9.0.1
  • Python version: 2.7.12
  • Operating system: Ubuntu 16.04

Description:

I maintain a package that has many dependencies, which are also conditional to a specific argument to setup.py.

If I pass this argument to pip, like this:

pip install ./ --global-option="--argument=opt1" -vvv

Then in the very first few lines I see the output:

Running command python setup.py egg_info

And the wrong list of dependencies is fetched (ie, as if I did not pass the argument at all).

If I run in the project directory the following command:

python setup.py egg_info --argument=opt1

Then the correct list of dependencies is added.

Can the specified global options be added to it, like they are for build and install?

@xavfernandez xavfernandez added the type: enhancement Improvements to functionality label Mar 28, 2017
@fabio-t
Copy link
Author

fabio-t commented Mar 28, 2017

Note: in this case I don't think the parameter should be passed to the dependencies' egg_info. I can see which this can be important for install options (prefix?), for example, but not global/build options (they would likely break dependencies).

@astrofrog
Copy link

Just a +1 for this feature request!

@chrahunt
Copy link
Member

chrahunt commented Sep 3, 2019

I'll mark this as awaiting PR and assume we'll discuss any backwards-compatibility concerns on the PR itself.

@chrahunt
Copy link
Member

chrahunt commented Dec 7, 2019

One problem with a naive implementation of this would be use cases like #6398, which pass additional commands in --global-option. We may need to introduce additional options to handle this case. In general it will probably be part of #5771 which I assume will result in a nicer framework for specifying dependency-specific info like this that impacts installation processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: PEP 517 impact Affected by PEP 517 processing state: awaiting PR Feature discussed, PR is needed type: enhancement Improvements to functionality
Projects
None yet
Development

No branches or pull requests

5 participants