-
-
Notifications
You must be signed in to change notification settings - Fork 257
Conversation
Rebased. Device tests pass in 36 seconds on my laptop which is about 12 times faster than on a physical device. |
This is really nice work! I am truly amazed! One small nit, though. Does it make sense to move |
I also thought about this but I came to the following conclusion. While it might be sensible to move some of it (for use in non-firmware parts), at least some of it should remain in |
@prusnak I think this is an acceptable solution |
- EMULATOR=1 HEADLESS=1 | ||
- DEBUG_LINK=1 | ||
before_script: | ||
- sed -i '/hidapi/d' "vendor/python-trezor/requirements.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-trezor contains --disable-hidapi
option in setup.py
, maybe we can try using pip install with --install-option
- I remember I was trying to use the same trick for trezor-core, but I failed, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prusnak I tried that at least 5 different ways and gave up. 😆 pip
will not pass provided options to ./setup.py egg_info
which is what it uses to gather dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, glad to know I am the only one who failed on this. Thanks :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prusnak There is an issue here but I don't imagine it will be fixed pypa/pip#4383
❤️ |
Emulator support with SDL2 or headless mode, persistent flash and UDP transport.