Merge pull request #8716 from McSinyx/fix-range-request-cache

Disable caching for range requests
pypa · Aug 5, 2020 · f51bd8f · f51bd8f
2 parents 3d3c7b6 + ffd6a38
commit f51bd8f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/news/50cf024d-0a74-44c8-b3e9-483dd826fff2.trivial b/news/50cf024d-0a74-44c8-b3e9-483dd826fff2.trivial
diff --git a/src/pip/_internal/network/lazy_wheel.py b/src/pip/_internal/network/lazy_wheel.py
@@ -194,8 +194,10 @@ def _check_zip(self):
     def _stream_response(self, start, end, base_headers=HEADERS):
         # type: (int, int, Dict[str, str]) -> Response
         """Return HTTP response to a range request from start to end."""
-        headers = {'Range': 'bytes={}-{}'.format(start, end)}
-        headers.update(base_headers)
+        headers = base_headers.copy()
+        headers['Range'] = 'bytes={}-{}'.format(start, end)
+        # TODO: Get range requests to be correctly cached
+        headers['Cache-Control'] = 'no-cache'
         return self._session.get(self._url, headers=headers, stream=True)
 
     def _merge(self, start, end, left, right):