Skip to content

Commit

Permalink
Deprecate Python 3.4
Browse files Browse the repository at this point in the history
  • Loading branch information
xavfernandez committed Jan 12, 2019
1 parent 5e573df commit b268c67
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
1 change: 1 addition & 0 deletions news/6106.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Deprecate support for Python 3.4
10 changes: 10 additions & 0 deletions src/pip/_internal/cli/base_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
install_req_from_editable, install_req_from_line,
)
from pip._internal.req.req_file import parse_requirements
from pip._internal.utils.deprecation import deprecated
from pip._internal.utils.logging import setup_logging
from pip._internal.utils.misc import (
get_prog, normalize_path, redact_password_from_url,
Expand Down Expand Up @@ -134,6 +135,15 @@ def main(self, args):
user_log_file=options.log,
)

if sys.version_info[:2] == (3, 4):
deprecated(
"Python 3.4 support has been deprecated. pip 19.1 will be the "
"last one supporting it. Please upgrade your Python as Python "
"3.4 won't be maintained after March 2019 (cf PEP 429).",
replacement=None,
gone_in='19.2',
)

# TODO: Try to get these passing down from the command?
# without resorting to os.environ to hold these.
# This also affects isolated builds and it should.
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,4 +349,4 @@ def in_memory_pip():
@pytest.fixture
def deprecated_python():
"""Used to indicate wheither pip deprecated this python version"""
return False
return sys.version_info[:2] == (3, 4)

0 comments on commit b268c67

Please sign in to comment.