Skip to content

Commit

Permalink
Merge pull request #8180 from sbidoul/wheel-absent-warning-sbi
Browse files Browse the repository at this point in the history
  • Loading branch information
pradyunsg committed May 18, 2020
1 parent c5150d4 commit a526f93
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
2 changes: 2 additions & 0 deletions news/8178.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Avoid unnecessary message about the wheel package not being installed
when a wheel would not have been built. Additionally, clarify the message.
16 changes: 8 additions & 8 deletions src/pip/_internal/wheel_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,6 @@ def _should_build(
# From this point, this concerns the pip install command only
# (need_wheel=False).

if not req.use_pep517 and not is_wheel_installed():
# we don't build legacy requirements if wheel is not installed
logger.info(
"Could not build wheels for %s, "
"since package 'wheel' is not installed.", req.name,
)
return False

if req.editable or not req.source_dir:
return False

Expand All @@ -87,6 +79,14 @@ def _should_build(
)
return False

if not req.use_pep517 and not is_wheel_installed():
# we don't build legacy requirements if wheel is not installed
logger.info(
"Using legacy setup.py install for %s, "
"since package 'wheel' is not installed.", req.name,
)
return False

return True


Expand Down

0 comments on commit a526f93

Please sign in to comment.