fixup! fixup! Make pip wheel cache what it built

pypa · Nov 3, 2019 · 978d9de · 978d9de
1 parent 30f2740
commit 978d9de
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/pip/_internal/wheel.py b/src/pip/_internal/wheel.py
@@ -1102,7 +1102,7 @@ def build(
         :param should_unpack: If True, after building the wheel, unpack it
             and replace the sdist with the unpacked version in preparation
             for installation.
-        :return: True if all the wheels built correctly.
+        :return: The list of InstallRequirement that failed to build.
         """
         # pip install uses should_unpack=True.
         # pip install never provides a _wheel_dir.
@@ -1170,9 +1170,6 @@ def build(
                     python_tag=python_tag,
                 )
                 if wheel_file:
-                    self.wheel_filenames.append(
-                        os.path.relpath(wheel_file, output_dir)
-                    )
                     if should_unpack:
                         # XXX: This is mildly duplicative with prepare_files,
                         # but not close enough to pull out to a single common
@@ -1198,7 +1195,7 @@ def build(
                         # extract the wheel into the dir
                         unpack_file(req.link.file_path, req.source_dir)
                     else:
-                        # copy from cache to target durectory
+                        # copy from cache to target directory
                         try:
                             ensure_dir(self._wheel_dir)
                             shutil.copy(
@@ -1212,6 +1209,9 @@ def build(
                             )
                             build_failure.append(req)
                             continue
+                    self.wheel_filenames.append(
+                        os.path.relpath(wheel_file, output_dir)
+                    )
                     build_success.append(req)
                 else:
                     build_failure.append(req)