Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _32_BIT_INTERPRETER for GraalPy #614

Closed
wants to merge 2 commits into from
Closed

Fix _32_BIT_INTERPRETER for GraalPy #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46df49e
Fix _32_BIT_INTERPRETER for GraalPy
isuruf Nov 12, 2022
fbb39e8
import struct
isuruf Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packaging/tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import logging
import platform
import struct
import subprocess
import sys
import sysconfig
Expand Down Expand Up @@ -37,7 +38,7 @@
}


_32_BIT_INTERPRETER = sys.maxsize <= 2**32
_32_BIT_INTERPRETER = (struct.calcsize("P") == 4)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this. Isn't 2**31-1 <= 2**32 ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iirc the point is if sys.maxint is larger than 2**32, int must be 64bit.



class Tag:
Expand Down