-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manylinux detection to be robust to incompatible ABIs #221
Conversation
1240cb2
to
1d6f755
Compare
This sets some groundwork for but doesn't fully address #217, since it does not add the corresponding platform tags. Cf pypa/pip#5391. |
I don't know anything about the ELF format so I'm not in a good position to review this. |
I'm reluctant to add a new platform tag for That being said, if @pypa/packaging-committers want me to add a new platform tag, I will do so. |
@mayeut if i686 wheels won't work on x32 then listing a more appropriate CPU architecture in the platform tag makes sense to me. |
@chrahunt, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several minor comments. In general this approach looks good and is mostly in-line with the changes that were made in pypa/pip#7102.
@chrahunt, sorry it took so long for me to be able to work on this. The new commit should answer all your remarks. I can squash the commit if need be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This is much easier to follow and will be easier to extend later if needed. Just one small comment, otherwise this looks good to me. Personally I would squash, but that's a decision that can also be made by whoever merges.
I squashed all commits and added some more tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
CI failures are not related to the changes in this PR. |
Glad someone else had a push do the same thing my PR did - and if you do not mind, I'll steal your comment. Still do not understand how #243 ever passed. |
78ba370
to
3e88626
Compare
`armv7l` machine overlaps multiple ABI (`armhf`, `armel`). The same goes for `i686` when running on `x86_64` kernel (`i686`, `x32`). This commit checks that ABI is compatible with the ones defined in PEP 513/571/599
This looks ready to merge. @brettcannon Would you like a chance to review/approve before merging? |
@brettcannon don't hold this PR up for my review; currently buried under other stuff. |
armv7l
machine overlaps multiple ABI (armhf
,armel
). The same goes fori686
when running onx86_64
kernel (i686
,x32
).This commit checks that ABI is compatible with the ones defined in PEP 513/571/599.
Partially addresses #217