-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split a pyproject.toml guide out of the "Declaring project metadata" specification #1350
Conversation
…specification Fixes pypa#1349
4ad541b
to
789d02b
Compare
Thanks @jeanas Shortcut to preview: https://python-packaging-user-guide--1350.org.readthedocs.build/en/1350/guides/writing-pyproject-toml/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like this PR. I'm concerned about removing content from a specification. Do you think the removal is necessary?
5440422
to
3cadeb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like having the new doc which will be helpful. I'm just not sure that it adds value to remove the examples from the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeanas I'm approving this PR since I like the new doc. I will leave to you and others when to merge re: spec changes. We can always add the removals back as needed at a later date.
Very happy to see the activity the past few weeks to make improvements. ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
More links maybe?
Thank you, @willingc. |
Fixes #1349