Revert update to wheel 0.32 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This problem is generating quite a lot of traffic. I propose to merge soon unless I here otherwise. |
|
It's unfortunate that our CI didn't notice any issue with #228... is there anything we could do to catch this kind of issue in the future? |
|
I guess we could try building a wheel that needs repairing in the tests. |
|
Sorry, guys, my bad
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about this - but Wheel 0.32 breaks auditwheel, and as auditwheel doesn't
have tests for the relevant code, I suspect it will be a while before it works
with 0.32.0 - see pypa/auditwheel#102
So, can I humbly ask that we revert to Wheel 0.3.1, in order to unbreak
auditwheel, in the meantime?