Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make follow-up improvements to validate_record #156

Closed
pradyunsg opened this issue Dec 13, 2022 · 2 comments
Closed

Make follow-up improvements to validate_record #156

pradyunsg opened this issue Dec 13, 2022 · 2 comments
Assignees
@pradyunsg
Labels
component: records Related to installer.records component: sources Related to WheelSource and friends type: task Something that needs to be done that is not a bug or feature

Comments

@pradyunsg
Copy link
Member

pradyunsg commented Dec 13, 2022 •
edited
Loading

There's also a few more changes to make around this (as a follow up to #105):

  • rename the argument to validate_contents, and make it kw-only.
  • should validate that everything has a hash/size even if validate_contents is False.
  • should validate that RECORD signatures are not mentioned in the RECORD.
  • should validate that the RECORD file is mentioned without hash or size.
  • documentation needs to present an example and add cross-references to/from WheelSource.validation_error.
@pradyunsg pradyunsg added the type: task Something that needs to be done that is not a bug or feature label Dec 13, 2022
@pradyunsg pradyunsg mentioned this issue Dec 13, 2022
Closed
@pradyunsg
Copy link
Member Author

FWIW, I'm also not a big fan of the inconsistency within test_sources.py around function tests vs method tests and would prefer to unify things under the TestWheelFile class.

@pradyunsg pradyunsg self-assigned this Dec 13, 2022
@pradyunsg pradyunsg added component: records Related to installer.records component: sources Related to WheelSource and friends labels Dec 13, 2022
@pradyunsg pradyunsg mentioned this issue Dec 27, 2022
Merged
@pradyunsg pradyunsg mentioned this issue Jan 30, 2023
Open
BlueGlassBlock added a commit to BlueGlassBlock/pypa-installer that referenced this issue Mar 2, 2023
@BlueGlassBlock
Refactor validate_record
c669d1f 
Address pypa#156
This was referenced Mar 2, 2023
Closed
Merged
@pradyunsg
Copy link
Member Author

Thanks @BlueGlassBlock! You're awesome! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pradyunsg pradyunsg

Labels
component: records Related to installer.records component: sources Related to WheelSource and friends type: task Something that needs to be done that is not a bug or feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pradyunsg