-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show hash values of files to be uploaded #87
Conversation
@webknjaz It should work properly now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meowmeowmeowcat thanks! I've applied some refactoring through the web UI without testing it — could you verify that it doesn't error out before I merge this?
I noticed you use the main PyPI in tests. It's recommended to use the test instance (TestPyPI) instead: https://test.pypi.org. FYI. |
It doesn't error out and generates the correct hash values. 👍 Final test for it: https://github.com/meowmeowmeowcat/test-repo/runs/4752022357?check_suite_focus=true#step:6:1 EDIT: I've fixed the bug below.
|
@@ -30,6 +30,10 @@ inputs: | |||
description: Show verbose output. | |||
required: false | |||
default: false | |||
print_hash: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that maybe it's better to make this plural. But it's too late now so I'll keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change of the public API. We'd have to wait until v2 or even v3 depending on how we decide to do deprecation. There are other things, I'd change like using kebab-case for the inputs but not today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, and I just realized that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may add a print_hashes
, and treat the current name as an undocumented alias.
Closes #62
Suggestions are welcomed.
Preview: https://github.com/meowmeowmeowcat/test-repo/runs/4746294453?check_suite_focus=true#step:5:16