Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc-exchange: add workflow_ref to debug msg #305

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

woodruffw
Copy link
Member

workflow_ref and job_workflow_ref diverge in the "reusable workflow from external repo" case, so having both in the debug output makes it a bit easier to root cause that kind of scenario 🙂

@woodruffw
Copy link
Member Author

CI failure looks unrelated:

  ERROR: failed to solve: Canceled: context canceled

@webknjaz
Copy link
Member

CI failure looks unrelated:

  ERROR: failed to solve: Canceled: context canceled

Yep, it was just too slow:

 smoke-test / smoke-test
The job running on runner GitHub Actions 196 has exceeded the maximum execution time of 2 minutes.

@webknjaz webknjaz enabled auto-merge November 24, 2024 02:00
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz merged commit 218af42 into pypa:unstable/v1 Nov 24, 2024
5 checks passed
@webknjaz
Copy link
Member

@woodruffw let's maybe also add a warning if the workflow is detected to be reusable?

@woodruffw
Copy link
Member Author

@woodruffw let's maybe also add a warning if the workflow is detected to be reusable?

Sounds good, I can do that tomorrow!

@webknjaz
Copy link
Member

Maybe we could tell people how exactly they should migrate and point them to subscribe to #166 for news when reusable workflow would become supported.

@webknjaz webknjaz added the enhancement New feature or request label Nov 26, 2024
@woodruffw woodruffw deleted the ww/debug-workflow-ref branch November 26, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants