Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --disable-pip #53

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add support for --disable-pip #53

merged 3 commits into from
Dec 12, 2024

Conversation

davidemonkeys
Copy link
Contributor

Adding support for the disable-pip parameter.

We are working on a project made with rye and have a specific requirements.lock file. Via command line, we were able to perform the assessment via pip-audit --disable-pip --requirement requirements.lock --no-deps but the GH action lacks the --disable-pip flag.

This PR intents do add such support.

It has been successfully tested on an private project.

Powered by TheAgileMonkeys team.

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM behaviorally, thanks @davidemonkeys!

Could you document this new setting in the README.md, next to the other settings? That would help other users discover and use it correctly 🙂

@davidemonkeys
Copy link
Contributor Author

@woodruffw sure, no problem.

README updated. Let me know if anything else is missing 😄

@woodruffw
Copy link
Member

Thanks @davidemonkeys, LGTM!

@woodruffw woodruffw merged commit fee84f2 into pypa:main Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants