Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin on requests (fixes #41) #42

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

Alexerson
Copy link
Contributor

@Alexerson Alexerson commented May 23, 2023

Pretty simple fix for #41 .

@woodruffw
Copy link
Member

Thanks @Alexerson!

Note the comment next to that pin: we can't just remove this, because we have other subdependency constraints 🙂

If you'd like to fully address this, you can update the pip-audit constraint from:

pip-audit ~= 2.0, >= 2.4.13

to:

pip-audit ~= 2.0, >= 2.5.6

...while also removing the requests pin. That will resolve the subdependency conflict (due to a release we made yesterday).

@Alexerson
Copy link
Contributor Author

Ah, sorry you’re right. Pushing this in a sec.

@woodruffw
Copy link
Member

Thank you! LGTM.

@woodruffw woodruffw merged commit cf52d21 into pypa:main May 23, 2023
@woodruffw
Copy link
Member

Thanks again! I'll push out a new version of this action momentarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants