pin CPython 3.8 installer on macosx10.9 #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
force-pushed
the
python-3.8-macosx10.9
branch
from
979ae0f
to
3b6adbe
Compare
mayeut
commented
May 8, 2021
bin/update_pythons.py
Outdated
| if version <= Version("3.8.9999"): | ||
| file_idents = ("macosx10.9.pkg",) | ||
| else: | ||
| file_idents = ("macos11.pkg", "macosx10.9.pkg") |
There was a problem hiding this comment.
Should we just drop the tuple here and just go ahead and define file_ident = "macos11.pkg" once and for all ?
There was a problem hiding this comment.
Nevermind, I went this way just to silence the MyPy issue - I guess I could have solved differently.
macosx11 installer requires macOS 11+ for CPython 3.8 while macosx11 installer for CPython 3.9+ only requires macOS 10.9+ on x86_64.
mayeut
force-pushed
the
python-3.8-macosx10.9
branch
from
3b6adbe
to
ada6c64
Compare
henryiii
reviewed
May 8, 2021
| if version <= Version("3.8.9999"): | ||
| file_ident = "macosx10.9.pkg" | ||
| else: | ||
| file_ident = "macos11.pkg" |
There was a problem hiding this comment.
We could instead take the old file identifier, and only look for that.
There was a problem hiding this comment.
This is fine for now, but that's a possible update later to remove the explicit version check.
henryiii
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macosx11 installer requires macOS 11+ for CPython 3.8 while macosx11 installer for CPython 3.9+ only requires macOS 10.9+ on x86_64.
c.f. comments in #663