-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin manylinux2010
images (CPython 2.7 support)
#594
Conversation
manylinux2010
image used to update dependenciesmanylinux2010
images
manylinux2010
imagesmanylinux2010
images (CPython 2.7 support)
This could be good for a I'll also open a PR for dropping Python 2.7 altogether. |
`manylinux2010` dropped CPython 2.7 Use the tag `2021-02-06-3d322a5` for dependency update which is the last supporting CPython 2.7
4ed8da8
to
6f217f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The 1.9 and backporting might need some further discussion and practicalities sorted out (about how we're going to achieve it, and what's the policy for backporting, etc), but this PR is independent of that. We'll need to pin this anyway :-)
Although, hmmm, wait. Now anyone building only Python 3.6 wheels would also be stuck on old manylinux2010 images? We could also introduce |
Yes. That's the idea behind making this an LTS then moving forward. I was more interested in making 2010 Py3 only, but still supporting 2.7 until it is dropped (or manylinux1 drops 2.7 support ;) ). I really wanted cibuildwheel to match manylinux. I thought there was open discussion about it but @mayeut seems to have gone ahead anyway in #596. What do we do now for manylinux 2014? |
I suppose builds with |
Yes, as mentioned in the docs (
This specific PR is in fact only here to allow things moving forward for everything except
@henryiii, I'm happy to discuss again the different options in #596 and I'll expand on that in that issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minimal required step to keep moving forward for 1.9.x. I think it's a no-brainer. :)
Let's merge then. |
manylinux2010
dropped CPython 2.7Use the tag
2021-02-06-3d322a5
which is the last supporting CPython 2.7