Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin manylinux2010 images (CPython 2.7 support) #594

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Feb 14, 2021

manylinux2010 dropped CPython 2.7
Use the tag 2021-02-06-3d322a5 which is the last supporting CPython 2.7

@mayeut mayeut changed the title Pin manylinux2010 image used to update dependencies Pin manylinux2010 images Feb 14, 2021
@mayeut mayeut changed the title Pin manylinux2010 images Pin manylinux2010 images (CPython 2.7 support) Feb 14, 2021
@mayeut mayeut marked this pull request as ready for review February 14, 2021 17:15
@mayeut
Copy link
Member Author

mayeut commented Feb 14, 2021

This could be good for a cibuildwheel 1.9.x LTS as mentioned in #580 (comment) and at least for master branch in its current state (the update workflow is failing right now: https://github.com/joerick/cibuildwheel/actions/runs/547039649).

I'll also open a PR for dropping Python 2.7 altogether.

`manylinux2010` dropped CPython 2.7
Use the tag `2021-02-06-3d322a5` for dependency update which is the last supporting CPython 2.7
Copy link
Member

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The 1.9 and backporting might need some further discussion and practicalities sorted out (about how we're going to achieve it, and what's the policy for backporting, etc), but this PR is independent of that. We'll need to pin this anyway :-)

@YannickJadoul
Copy link
Member

Although, hmmm, wait. Now anyone building only Python 3.6 wheels would also be stuck on old manylinux2010 images?

We could also introduce CIBW_MANYLINUX_X86_64_IMAGE=python27, and try detecting whether Python 2.7 is present?

@henryiii
Copy link
Contributor

henryiii commented Feb 14, 2021

would also be stuck on old manylinux2010

Yes. That's the idea behind making this an LTS then moving forward. I was more interested in making 2010 Py3 only, but still supporting 2.7 until it is dropped (or manylinux1 drops 2.7 support ;) ). I really wanted cibuildwheel to match manylinux. I thought there was open discussion about it but @mayeut seems to have gone ahead anyway in #596.

What do we do now for manylinux 2014?

@YannickJadoul
Copy link
Member

What do we do now for manylinux 2014?

I suppose builds with manylinux2014 fail if Python 2.7 isn't deselected?

@mayeut
Copy link
Member Author

mayeut commented Feb 15, 2021

I suppose builds with manylinux2014 fail if Python 2.7 isn't deselected?

Yes, as mentioned in the docs (Note that manylinux2014 doesn't support builds with Python 2.7 - when building with manylinux2014, skip Python 2.7 using CIBW_SKIP (see example below).)

Although, hmmm, wait. Now anyone building only Python 3.6 wheels would also be stuck on old manylinux2010 images?

We could also introduce CIBW_MANYLINUX_X86_64_IMAGE=python27, and try detecting whether Python 2.7 is present?

@YannickJadoul,

This specific PR is in fact only here to allow things moving forward for everything except manylinux2010. If you look at the current situation, everything is stuck right now (unless more manual actions are taken) because the update pipeline is failing.
This only fixes this situation to allow everything else to update correctly. The points you are raising are valid but might be addressed later on.

I was more interested in making 2010 Py3 only, but still supporting 2.7 until it is dropped (or manylinux1 drops 2.7 support ;) ). I really wanted cibuildwheel to match manylinux. I thought there was open discussion about it but @mayeut seems to have gone ahead anyway in #596.

@henryiii, I'm happy to discuss again the different options in #596 and I'll expand on that in that issue.

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minimal required step to keep moving forward for 1.9.x. I think it's a no-brainer. :)

@mayeut mayeut merged commit 14f2f4e into pypa:master Feb 16, 2021
@mayeut
Copy link
Member Author

mayeut commented Feb 16, 2021

Let's merge then.

@mayeut mayeut deleted the update-dependencies-cp27 branch February 16, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants