Bump Ruff to 0.8.0 #2092
Merged
Bump Ruff to 0.8.0 #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Nov 22, 2024
| @@ -9,7 +9,6 @@ | |||
| "PLATFORMS", | |||
| "PathOrStr", | |||
| "PlatformName", | |||
| "PLATFORMS", | |||
There was a problem hiding this comment.
Ruff would have just moved this higher up, but I noticed that it actually appears twice in __all__ here, so I removed the duplicate entry!
There was a problem hiding this comment.
Nice, I wonder if Ruff could also remove it eventually?
There was a problem hiding this comment.
yeah definitely. I wondered this when I implemented RUF022 back in January, but I held off from doing it as part of RUF022 as it felt outside of its purview -- RUF022 is about style/formatting, whereas this feels like more of a correctness error. So it would have to be a different rule. But it's a rule I'd support adding, for sure!
henryiii
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I just released Ruff 0.8.0. This release removes
PT004, which had been deprecated for a few releases, so Ruff 0.8.0 would have started emitting warnings when lintingcibuildwheeldue to the fact that you havePT004explicitly ignored in your Ruff config.This PR gets rid of
PT004from your Ruff config. There's also some additional changes made here due to the stabilisation ofunsorted-dunder-all(RUF022) in this release -- let me know if these are unwelcome, and I can add them to thetool.ruff.lint.ignorelist.