Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make container-engine a build (non-global) option #1792

Merged
merged 3 commits into from
May 20, 2024

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Mar 15, 2024

Lets users specify different container-engine settings for different builds using TOML overrides. Especially useful with the create_args setting, such as #1771.

Lets users specify different container-engine settings for different
builds. Especially useful with the create_args setting, such as 1771.
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be updated in the schema. I can do that if it's helpful.

cibuildwheel/oci_container.py Outdated Show resolved Hide resolved
@joerick
Copy link
Contributor Author

joerick commented Apr 26, 2024

I've had a go at that @henryiii . Pretty simple to do, thanks to the tooling. I don't know how to update the schemastore, if that's necessary? Actually, maybe that should be part of the release process?

@henryiii
Copy link
Contributor

henryiii commented May 7, 2024

You have to make a PR to SchemaStore. Not sure how easy that would be to automate. But it's a good idea to do it around release time if the schema changes.

@henryiii henryiii merged commit 9d5f5e6 into main May 20, 2024
20 checks passed
@henryiii henryiii deleted the container-engine-build-option branch May 20, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants