Add the ability to pass extra flags to a build frontend through CIBW_BUILD_FRONTEND #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Aug 27, 2023
|
Would love a review on this @henryiii if you have time? |
henryiii
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1580.
Adds the ability to pass extra arguments to the build frontend using an option like
CIBW_BUILD_FRONTEND=pip; args: --no-build-isolation. The mini-syntax is the same as CIBW_CONTAINER_ENGINE.I liked this approach because it adds extra flexibility to the existing CIBW_BUILD_FRONTEND option in a backward-compatible way. Also, options are always going to be different between pip and build, so it makes sense to nest those within this option - if you change the build frontend, you have to change the args too.