feature: add musllinux_1_2 support #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
approved these changes
Jul 29, 2023
|
The test error on GHA is: I'll try to check what can be done. |
We are reaching disk space limits (14 GB) when running tests. Add a fixture to clean-up docker images after tests. This fixture is applied on tests that pull a specific image for one test only in order not to take too much time pulling that image many times.
henryiii
approved these changes
Aug 1, 2023
joerick
reviewed
Aug 7, 2023
Comment on lines
+34
to
+57
| @pytest.fixture() | ||
| def docker_cleanup() -> Generator[None, None, None]: | ||
| def get_images() -> set[str]: | ||
| images = subprocess.run( | ||
| ["docker", "image", "ls", "--format", "{{json .ID}}"], | ||
| text=True, | ||
| check=True, | ||
| stdout=subprocess.PIPE, | ||
| ).stdout | ||
| return {json.loads(image.strip()) for image in images.splitlines() if image.strip()} | ||
|
|
||
| if detect_ci_provider() is None or platform != "linux": | ||
| try: | ||
| yield | ||
| finally: | ||
| pass | ||
| return | ||
| images_before = get_images() | ||
| try: | ||
| yield | ||
| finally: | ||
| images_after = get_images() | ||
| for image in images_after - images_before: | ||
| subprocess.run(["docker", "rmi", image], check=False) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
musllinux_1_2 support has been merged in the manylinux repo.
Now adding this to cibuildwheel.