Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: improve console output #749

Merged
merged 14 commits into from
Mar 5, 2024

Conversation

layday
Copy link
Member

@layday layday commented Mar 1, 2024

No description provided.

@layday layday force-pushed the feat-better-console-output branch from 8a9ecfb to 21b70c0 Compare March 1, 2024 19:27
@layday
Copy link
Member Author

layday commented Mar 1, 2024

Screenshot 2024-03-01 at 21 28 30

@henryiii
Copy link
Contributor

henryiii commented Mar 1, 2024

Would it make sense to remove the bold on the package names? I think that would look a little more distinct:

Screenshot 2024-03-01 at 2 37 30 PM

@layday
Copy link
Member Author

layday commented Mar 1, 2024

That makes sense, I've changed it.

@henryiii
Copy link
Contributor

henryiii commented Mar 1, 2024

Much better, I think:

Screenshot 2024-03-01 at 3 55 57 PM

@layday
Copy link
Member Author

layday commented Mar 1, 2024

Any thoughts on the verbosity option?

@henryiii
Copy link
Contributor

henryiii commented Mar 1, 2024

Basically just passes through to the underlying pip? Seems fine.

@layday layday force-pushed the feat-better-console-output branch 2 times, most recently from a0dbeb1 to 88cca22 Compare March 5, 2024 15:17
@layday layday force-pushed the feat-better-console-output branch from 88cca22 to 27c1c32 Compare March 5, 2024 15:56
@layday layday marked this pull request as ready for review March 5, 2024 16:07
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 0cbca17 into pypa:main Mar 5, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants