Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setuptools to 51.3.0 #804

Merged
merged 4 commits into from
Jan 17, 2021

Conversation

pyup-bot
Copy link
Collaborator

This PR updates setuptools from 51.1.2 to 51.3.0.

Changelog

51.3.0

-------


Changes
^^^^^^^
* 1390: Newlines in metadata description/Summary now trigger a ValueError.
* 2481: Define ``create_module()`` and ``exec_module()`` methods in ``VendorImporter``
to get rid of ``ImportWarning`` -- by :user:`hroncok`
* 2489: ``pkg_resources`` behavior for zipimport now matches the regular behavior, and finds
``.egg-info`` (previoulsy would only find ``.dist-info``) -- by :user:`thatch`
* 2529: Fixed an issue where version tags may be added multiple times

51.2.0

-------


Changes
^^^^^^^
* 2493: Use importlib.import_module() rather than the deprectated loader.load_module()
in pkg_resources namespace delaration -- by :user:`encukou`

Documentation changes
^^^^^^^^^^^^^^^^^^^^^
* 2525: Fix typo in the document page about entry point. -- by :user:`jtr109`

Misc
^^^^
* 2534: Avoid hitting network during test_easy_install.
Links

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #804 (8419450) into master (05f6186) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files          15       15           
  Lines        2177     2177           
  Branches      318      318           
=======================================
  Hits         1743     1743           
  Misses        318      318           
  Partials      116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f6186...8419450. Read the comment docs.

@ichard26
Copy link
Member

This might be a bad idea, it caused this mess for Black.

Move to a newer version since it exists ...
Move to a newer version since it exists ...
@cooperlees
Copy link
Contributor

Our CI covers install and actually does a bandersnatch run. So I feel that proves this does not cause the same mess here - But I'll move it to 51.3.1 ... Would have expected the bot to move before me ...

Copy link
Contributor

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cooperlees cooperlees merged commit 5dd211b into master Jan 17, 2021
@cooperlees cooperlees deleted the pyup-update-setuptools-51.1.2-to-51.3.0 branch January 17, 2021 17:37
@ichard26
Copy link
Member

ichard26 commented Jan 17, 2021

Well I was more worried about someone setting up a dev environment with setuptools==51.3.0 that they can't install certain packages into and being rightfully confused. And since people rarely sync their installed packages to the newest version of the requirements file, they could end up with that broken version of setuptools for quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants