-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Action for pushing to Docker Hub on Release #482
Add GH Action for pushing to Docker Hub on Release #482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 81.59% 81.59%
=======================================
Files 10 10
Lines 1157 1157
Branches 168 168
=======================================
Hits 944 944
Misses 171 171
Partials 42 42 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already build on every commit to master. I feel we just need something to tag the build as the release.
1 way could be:
- See if commit has a Git tag and, if so, mirror it to docker hub tags?
I see. Would using https://github.com/elgohr/Publish-Docker-Github-Action/blob/master/README.md#tag_names to tag the images work out? |
Yup - Seems all we need is |
There might be a race before the commit gets the release tag ...
|
Interesting, let me test this out. |
This is blocked for the meantime, my local Docker instance seems to be causing issues. |
Added the Github Action for automating pushing the `pypa/bandersnatch` image to Docker Hub when a new release is published. New release here means An Annoteted Tag Push to the master branch Closes #88
Pulled this from the graves! Apologies, I get what I deserve for distrohopping so frequently!
So I tested this, and it seems like it only tags the image when an annotated tag (which is a tag + commit) is pushed, so it only creates an image with the tag name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say lets merge and see what happens :)
Added the Github Action for automating pushing the
pypa/bandersnatch
image to Docker Hub when a new release in published.
Closes #88