Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the option to skip setting library SONAMEs #472

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pvallet
Copy link

@pvallet pvallet commented Jan 2, 2024

I am adding this option locally as I ended up needing it to circumvent this problem I encountered, so I figured I might as well create a PR:
https://stackoverflow.com/questions/77733250/using-patchelf-to-change-the-soname-of-libgldispatch-so-breaks-its-functionality

While not the common flow, it does seem that being able to skip setting the SONAMEs and only relying on file names can have its uses in some cases.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.10%. Comparing base (45a8c00) to head (de6ecb3).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/auditwheel/repair.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   92.17%   92.10%   -0.07%     
==========================================
  Files          20       20              
  Lines        1252     1254       +2     
  Branches      304      305       +1     
==========================================
+ Hits         1154     1155       +1     
  Misses         56       56              
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy requested a review from mayeut January 2, 2024 20:56
@pvallet
Copy link
Author

pvallet commented Jan 15, 2024

Hello! Is there any way I could help push this forward? Should I create some tests for the new option? I hadn’t made them as the option I was taking inspiration from (no update tags) didn’t have any, but I could definitely add some

@mayeut
Copy link
Member

mayeut commented Feb 3, 2024

I'm not almost sure that we don't want to see this happening.
Copying without renaming/changing the SONAME is likely to break things in different environments.
While libOpenGL.so can't be whitelisted, I think it falls in the category where it can be excluded from being grafted altogether: #368

cc @lkollar for another opinion on the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants