Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message in case of NonPlatformWheel error #393

Merged
merged 4 commits into from
Oct 9, 2022

Conversation

CaselIT
Copy link
Contributor

@CaselIT CaselIT commented Aug 24, 2022

The current log message in case a wheel file contains no compiled extension is not very clear regarding that's the issue is.
I've tried to add a clarification that I how will make it clearer for uses to understand what when wrong

(I opened pypa/cibuildwheel#1247 since it was not clear to me that the error meant, I though it was complaining about the file name abi identifier or something similar)

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 92.42% // Head: 92.42% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fc4c4a9) compared to base (ef280f2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          23       23           
  Lines        1267     1268    +1     
  Branches      311      311           
=======================================
+ Hits         1171     1172    +1     
  Misses         55       55           
  Partials       41       41           
Impacted Files Coverage Δ
src/auditwheel/main_addtag.py 89.47% <100.00%> (ø)
src/auditwheel/main_repair.py 90.62% <100.00%> (ø)
src/auditwheel/main_show.py 82.75% <100.00%> (ø)
src/auditwheel/wheel_abi.py 97.01% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CaselIT
Copy link
Contributor Author

CaselIT commented Aug 25, 2022

It seems that the fails in the pipeline are not connected to the changes in this PR, but are due to travis ci worker handing

src/auditwheel/main_addtag.py Outdated Show resolved Hide resolved
@CaselIT CaselIT requested a review from mayeut October 9, 2022 14:12
@CaselIT
Copy link
Contributor Author

CaselIT commented Oct 9, 2022

I've updated.

I've taken the liberty of creating a constant with the message, since it was used in 3 different places, but I'm not sure if where I placed it is the correct place. I can remove it if you prefer not having it

src/auditwheel/wheel_abi.py Outdated Show resolved Hide resolved
@CaselIT CaselIT requested a review from mayeut October 9, 2022 14:28
src/auditwheel/wheel_abi.py Outdated Show resolved Hide resolved
@CaselIT CaselIT requested a review from mayeut October 9, 2022 15:09
@mayeut mayeut merged commit 73c9f17 into pypa:main Oct 9, 2022
@mayeut
Copy link
Member

mayeut commented Oct 9, 2022

thanks @CaselIT !

@CaselIT CaselIT deleted the NonPlatformWheel_logs branch October 10, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants