Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SOURCE_DATE_EPOCH #348

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Add support for SOURCE_DATE_EPOCH #348

merged 1 commit into from
Dec 11, 2021

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented Nov 19, 2021

Setting SOURCE_DATE_EPOCH in the environment will set the time stamps
of all files and directories in the produced wheels to the specified
value.

Closes: #346

@lkollar lkollar self-assigned this Nov 19, 2021
@lkollar lkollar force-pushed the reproducible branch 3 times, most recently from 7f3d674 to 5f8037e Compare November 21, 2021 21:42
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #348 (a44bc50) into main (b1d354a) will decrease coverage by 0.98%.
The diff coverage is 85.29%.

❗ Current head a44bc50 differs from pull request most recent head 79806ae. Consider uploading reports for the commit 79806ae to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   92.04%   91.06%   -0.99%     
==========================================
  Files          23       22       -1     
  Lines        1244     1253       +9     
  Branches      270      288      +18     
==========================================
- Hits         1145     1141       -4     
- Misses         55       61       +6     
- Partials       44       51       +7     
Impacted Files Coverage Δ
src/auditwheel/policy/__init__.py 98.21% <50.00%> (-1.79%) ⬇️
src/auditwheel/wheeltools.py 88.57% <66.66%> (-1.06%) ⬇️
src/auditwheel/tools.py 92.18% <93.33%> (-0.41%) ⬇️
src/auditwheel/lddtree.py 90.38% <100.00%> (ø)
src/auditwheel/policy/libc.py 100.00% <100.00%> (ø)
src/auditwheel/policy/musllinux.py 100.00% <100.00%> (ø)
src/auditwheel/main_addtag.py 78.94% <0.00%> (-7.90%) ⬇️
src/auditwheel/main.py 94.44% <0.00%> (-5.56%) ⬇️
src/auditwheel/wheel_abi.py 94.73% <0.00%> (-2.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d354a...79806ae. Read the comment docs.

@lkollar lkollar force-pushed the reproducible branch 3 times, most recently from 127c943 to 992a65a Compare November 23, 2021 22:33
@auvipy auvipy requested a review from mayeut November 24, 2021 08:22
@lkollar lkollar force-pushed the reproducible branch 4 times, most recently from 4d5c5a2 to 8e111ef Compare November 29, 2021 21:50
@lkollar lkollar marked this pull request as ready for review December 6, 2021 21:34
Setting `SOURCE_DATE_EPOCH` in the environment will set the time stamps
of all files and directories in the produced wheels to the specified
value.
@lkollar lkollar force-pushed the reproducible branch 3 times, most recently from f00a123 to 79806ae Compare December 8, 2021 10:29
@lkollar

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting SOURCE_EPOCH_DATE in auditwheel for reproducibily
2 participants