Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test with python 3.10 #345

Merged
merged 2 commits into from
Nov 20, 2021
Merged

chore: test with python 3.10 #345

merged 2 commits into from
Nov 20, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Nov 14, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #345 (1abb5bc) into main (b1d354a) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   92.04%   92.28%   +0.24%     
==========================================
  Files          23       23              
  Lines        1244     1244              
  Branches      270      289      +19     
==========================================
+ Hits         1145     1148       +3     
  Misses         55       55              
+ Partials       44       41       -3     
Impacted Files Coverage Δ
src/auditwheel/elfutils.py 95.04% <0.00%> (+0.99%) ⬆️
src/auditwheel/main_show.py 82.75% <0.00%> (+1.72%) ⬆️
src/auditwheel/main_addtag.py 89.47% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d354a...1abb5bc. Read the comment docs.

lkollar
lkollar previously approved these changes Nov 15, 2021
@lkollar lkollar dismissed their stale review November 15, 2021 09:51

Oops missed the failing test

@lkollar
Copy link
Contributor

lkollar commented Nov 15, 2021

I wonder if the test failure is because numpy 1.19.2 has no wheel for Python 3.10.

@mayeut
Copy link
Member Author

mayeut commented Nov 16, 2021

I wonder if the test failure is because numpy 1.19.2 has no wheel for Python 3.10.

We're building from sources so no, that's not the reason. I'll update all tests this week for them to pass.
e.g. manylinux1 does not have python 3.10, numpy should be updated (not sure there's a version which supports 3.6->3.10, might need to configure the numpy version depending on the python version).

@mayeut mayeut merged commit da34a03 into pypa:main Nov 20, 2021
@mayeut mayeut deleted the python-3.10 branch November 20, 2021 09:38
@mayeut mayeut mentioned this pull request Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants