-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract using zipfile preserving permission #312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 91.28% 91.24% -0.05%
==========================================
Files 20 20
Lines 1102 1108 +6
Branches 237 239 +2
==========================================
+ Hits 1006 1011 +5
Misses 54 54
- Partials 42 43 +1
Continue to review full report at Codecov.
|
@mayeut Can you approve running workflows ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add test too
That would require adding a wheel file with permissions, should I add such a wheel file and then test its permission after extract ? |
@mayeut If you can add a test on the master branch then I can rebase on it and we can check if this change works as expected as the earlier was working. |
Thanks for the PR.
I unfortunately won't have time for this in the foreseeable future. If you have time to add the test as @auvipy asked, I think it would be enough for now (or at least it would help doing some more checks based on this new test).
Yes, the smaller possible wheel file but covering as much permission bits as possible. |
Fixes #258