Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract using zipfile preserving permission #312

Closed
wants to merge 1 commit into from
Closed

Extract using zipfile preserving permission #312

wants to merge 1 commit into from

Conversation

kumaraditya303
Copy link

@kumaraditya303 kumaraditya303 commented Jul 2, 2021

Fixes #258

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #312 (72487a8) into master (b0762a9) will decrease coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   91.28%   91.24%   -0.05%     
==========================================
  Files          20       20              
  Lines        1102     1108       +6     
  Branches      237      239       +2     
==========================================
+ Hits         1006     1011       +5     
  Misses         54       54              
- Partials       42       43       +1     
Impacted Files Coverage Δ
auditwheel/tools.py 85.71% <88.88%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0762a9...72487a8. Read the comment docs.

@kumaraditya303 kumaraditya303 marked this pull request as ready for review July 2, 2021 06:27
@kumaraditya303
Copy link
Author

@mayeut Can you approve running workflows ?

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add test too

@kumaraditya303
Copy link
Author

can you add test too

That would require adding a wheel file with permissions, should I add such a wheel file and then test its permission after extract ?

@kumaraditya303
Copy link
Author

@mayeut If you can add a test on the master branch then I can rebase on it and we can check if this change works as expected as the earlier was working.

@mayeut
Copy link
Member

mayeut commented Jul 3, 2021

@kumaraditya303,

Thanks for the PR.

If you can add a test on the master branch then I can rebase on it and we can check if this change works as expected as the earlier was working.

I unfortunately won't have time for this in the foreseeable future. If you have time to add the test as @auvipy asked, I think it would be enough for now (or at least it would help doing some more checks based on this new test).

That would require adding a wheel file with permissions, should I add such a wheel file and then test its permission after extract ?

Yes, the smaller possible wheel file but covering as much permission bits as possible.

mayeut added a commit to mayeut/auditwheel that referenced this pull request Aug 22, 2021
This removes the need to have `unzip` installed.

fixes pypa#258
closes pypa#312
mayeut added a commit to mayeut/auditwheel that referenced this pull request Aug 24, 2021
This removes the need to have `unzip` installed.

fixes pypa#258
closes pypa#312
@auvipy auvipy closed this in #324 Aug 28, 2021
auvipy pushed a commit that referenced this pull request Aug 28, 2021
This removes the need to have `unzip` installed.

fixes #258
closes #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace unzip usage with Python's zipfile
3 participants