Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python slim images to run tests #308

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 22, 2021

This should speed-up the tests a bit.

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #308 (7939153) into master (0c59594) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          20       20           
  Lines        1102     1102           
  Branches      237      237           
=======================================
  Hits         1006     1006           
  Misses         54       54           
  Partials       42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c59594...7939153. Read the comment docs.

This should speed-up the tests a bit
@mayeut
Copy link
Member Author

mayeut commented May 22, 2021

@lkollar,

This was mostly to check that TravisCI builds were still triggered following an issue on the Travis CI pypa account.
Nevertheless, I still think it's a good thing to use the slim image.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slim is better

@mayeut mayeut merged commit e5d99f0 into pypa:master May 24, 2021
@mayeut mayeut deleted the python-slim branch May 29, 2021 08:29
@mayeut mayeut mentioned this pull request Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants