Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for auditwheel to depend on wheel 0.34 #223

Merged
merged 2 commits into from
Jan 28, 2020
Merged

fixes for auditwheel to depend on wheel 0.34 #223

merged 2 commits into from
Jan 28, 2020

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Jan 28, 2020

wheel in version 0.34 introduce fix for pypy tags pypa/wheel#328

@Czaki Czaki mentioned this pull request Jan 28, 2020
Merged
@codecov
Copy link

codecov bot commented Jan 28, 2020 •
edited
Loading

Codecov Report

Merging #223 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files          19       19           
  Lines         976      976           
  Branches      214      214           
=======================================
  Hits          851      851           
  Misses         86       86           
  Partials       39       39
Impacted Files Coverage Δ
auditwheel/wheeltools.py 89.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4a86b...33d84d8. Read the comment docs.

lkollar
lkollar requested changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@lkollar lkollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Czaki for the PR! This is a much needed upgrade. I just have one comment.

auditwheel/wheeltools.py Outdated
@@ -27,6 +28,16 @@ class WheelToolsError(Exception):
pass


def open_for_csv(name, mode):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that auditwheel only runs on Python 3 and there is only one place where this function is called, we could safely replace that call with open(name, mode, newline='', encoding='utf-8'). That avoids the unnecessary version check and makes the code more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduce this change. Could you restart failed steep. It fail on timeout error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted the ppc64 build.

@lkollar lkollar merged commit 67ba9ff into pypa:master Jan 28, 2020
@Czaki
Copy link
Contributor Author

Czaki commented Jan 28, 2020

@lkollar When you think it will be next release?

This was referenced Mar 2, 2020
Closed
Closed
tseaver added a commit to googleapis/python-crc32c that referenced this pull request Aug 6, 2020
@tseaver
fix: pin newer 'wheel' version
61cd223 
See: pypa/auditwheel#223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkollar lkollar lkollar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Czaki @lkollar