Update manylinux2010 policy with CentOS6-i686 #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
manylinux2010
lacks symbols for 32-bit CentOS 6 . Runningcalculate_symbol_versions.py
with docker image i386/centos:6 shows:To cover CentOS-6 i686 properly, I merged this result to manylinux2010 in
policy.json
. Actually it shows differences onGLIBC
andGCC
but I updatedGLIBC
only because GCC 4.5.0 seems a bit strange.From glibc source, i386 and x86_64 has a different version for the same function.
open
function, for example,GLIBC_2.0
is assigned on i386 butGLIBC_2.2.5
is on x86_64.As a double-check, I also ran
readelf -Ws libgcc_s.so.1 | grep @@ | sed -En 's/(.*)@@(.*)/\2/p' | sort -u
command on both CentOS6 32bits and 64bits to display all version symbols.