Update tests for manylinux2010 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopened because for some reason Travis wasn't noticing the second commit. |
Numpy built on manylinux2010 is not actually manylinux1 compatible, that was an artifact of reusing the cached wheel built on manylinux1.
ehashman
reviewed
Apr 11, 2019
| expected_files = 3 # We end up repairing the wheel twice to manylinux1 | ||
|
|
||
| assert len(filenames) == expected_files | ||
| # Regardless of build environment, wheel only needs manylinux1 symbols |
There was a problem hiding this comment.
I was gonna ask a question about this behaviour change but it's addressed in the commit message of 46619cd. Thanks for catching that.
ehashman
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's now an official image and pip supports manylinux2010, so these workarounds should be unnecessary.