Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deprecation warning of log.warn #120

Merged
merged 1 commit into from
Nov 18, 2018
Merged

Fixed deprecation warning of log.warn #120

merged 1 commit into from
Nov 18, 2018

Conversation

atombrella
Copy link
Contributor

No description provided.

ehashman
ehashman reviewed Nov 13, 2018
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little mystified by this one. logging.warning is coming directly from the logging library rather than our current instance of the logger, log. Why doesn't that work? Should we call log.warning?

@atombrella
Copy link
Contributor Author

@ehashman That works as well. Updated. PyCharm just highlighted the deprecation warning of log.warn.

@ehashman ehashman merged commit b95f9a2 into pypa:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atombrella @ehashman