Use assumed ABI3 version for shared objects without ".abi3."

[vadz]

Allow auditing arbitrary shared objects, not necessarily containing ".abi3." in their name, if --assume-minimum-abi3 option is specified: suppose that all shared objects use this ABI3 version then.

This makes the tool more convenient to use for non-wheel-packaged extensions.

Also specify the default, 3.2, ABI version in a single place only and use "None" instead of the default value elsewhere.

---

Sorry, I couldn't prevent myself from making this PR, implementing the suggestion discussed in #117. This may address #116 too, but mostly it makes the tool much more convenient for me to use, as I don't have to rename all the files (or create symlinks for them) before running it on them.

[vadz]

And sorry for the force pushes too, I forgot to run make lint (and I am still not sure how am I supposed to do it properly, to be honest, as I don't have mypy, that it tries to run at the end, locally).

[woodruffw]

And sorry for the force pushes too, I forgot to run make lint (and I am still not sure how am I supposed to do it properly, to be honest, as I don't have mypy, that it tries to run at the end, locally).

No problem. If you run make lint, it should create a temporary environment for you and run mypy within it -- you don't need to install anything explicitly.

[vadz]

No problem. If you run make lint, it should create a temporary environment for you and run mypy within it -- you don't need to install anything explicitly.

Somehow it doesn't for me:

(env) [.../abi3audit(use-min-assumed-abi3-for-so)] $ make lint
. env/bin/activate && \
	ruff format --check abi3audit/_state.py abi3audit/_cli.py abi3audit/__init__.py abi3audit/__main__.py abi3audit/_object.py abi3audit/_cache.py abi3audit/_audit.py abi3audit/_extract.py test/test_minimum_version.py test/test_audit.py test/__init__.py test/test_extract.py && \
	ruff check abi3audit/_state.py abi3audit/_cli.py abi3audit/__init__.py abi3audit/__main__.py abi3audit/_object.py abi3audit/_cache.py abi3audit/_audit.py abi3audit/_extract.py test/test_minimum_version.py test/test_audit.py test/__init__.py test/test_extract.py && \
	mypy abi3audit
12 files already formatted
/bin/sh: 4: mypy: not found
make: *** [Makefile:52: lint] Error 127

Please let me know if you think it's worth debugging this further.

[woodruffw]

Weird -- it's listed as a dev-dep:

abi3audit/pyproject.toml

Line 39 in be052e5

lint = ["bandit", "interrogate", "mypy", "ruff", "types-requests"]

Could you try deleting your the current venv and re-running make lint? If that still doesn't work, I can look into it further.

[vadz]

OK, I see what's going on here: if you start by running make lint it indeed works as expected, but if you start by running make test INSTALL_EXTRA=test, as I had originally done, make lint doesn't work later because mypy is missing. IMHO it's a (small) bug, but it's easy to work around, of course.

And thanks for merging this PR, it makes testing ABI compatibility much simpler for us!

[woodruffw]

OK, I see what's going on here: if you start by running make lint it indeed works as expected, but if you start by running make test INSTALL_EXTRA=test, as I had originally done, make lint doesn't work later because mypy is missing. IMHO it's a (small) bug, but it's easy to work around, of course.

Aha, that makes sense! Thanks for root-causing; I'll look at making a small fix for that.

And no problem, thank you for sending a PR! I greatly appreciate it.