FIX Check if future is done before trying to set a result on it #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
invalid-state-future
branch
2 times, most recently
from
b71af4e
to
9b8f5cc
Compare
|
So where we called this |
hoodmane
force-pushed
the
invalid-state-future
branch
from
27f2129
to
337517a
Compare
|
It's a bit complicated, I haven't sifted through the full control flow. Here's the full traceback, but it's hard to find anything micropip related there. Presumably we cancelled a Future and then it later got sent a result from the browser event loop. We need to throw it away if we're already done. Traceback |
It's probably from js import fetch
async def f():
while True:
await fetch("/")
from asyncio import *
f = ensure_future(f())
f.cancel()Running this and you will see a similar |
|
Thanks for the test case. |
ryanking13
reviewed
Jun 5, 2024
hoodmane
force-pushed
the
invalid-state-future
branch
from
c9629d3
to
35fb788
Compare
hoodmane
force-pushed
the
invalid-state-future
branch
from
d3ea1b4
to
05b839e
Compare
Otherwise, future raises invalid state error. Question: should we try to avoid getting to the point where we call this in the first place??
hoodmane
force-pushed
the
invalid-state-future
branch
from
1f7c86d
to
18398b7
Compare
for more information, see https://pre-commit.ci
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jun 7, 2024
…ide#4837) Otherwise, the future raises invalid state error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, future raises invalid state error. Question: should we try to avoid getting to the point where we call this in the first place??
cc @CNSeniorious000 this fixes the invalid state errors on pyodide/micropip#111
Description