Fix fitz.Pixmap colorspace conversion.
#3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructor `Pixmap(colorspace, pixmap)` previously always incorrectly converted via a greyscale proofing colorspace. Fixed similar bug in `Page.insert_image()` if we process the pixmap. Also fixed creation of `Colorspace` from a `mupdf.FzColorspace` - this would previously always created a RGB `Colorspace`. Address #3058
JorjMcKie
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructor
Pixmap(colorspace, pixmap)previously always incorrectly converted via a greyscale proofing colorspace.Fixed similar bug in
Page.insert_image()if we process the pixmap.Also fixed creation of
Colorspacefrom amupdf.FzColorspace- this would previously always created a RGBColorspace.Address #3058