Skip to content

Commit

Permalink
scripts/sysinstall.py:Avoid errors from upgrading system pip.
Browse files Browse the repository at this point in the history
`sudo pip --upgrade pip` can fail to install apt's pip.
  • Loading branch information
julian-smith-artifex-com committed Jan 9, 2025
1 parent 4b531cb commit 26a8093
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/sysinstall.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def run(command, env_extra=None):
#
if pip == 'sudo':
log('## Installing Python packages required for building MuPDF and PyMuPDF.')
run(f'sudo pip install --upgrade pip')
#run(f'sudo pip install --upgrade pip') # Breaks on Github see: https://github.com/pypa/get-pip/issues/226.
names = test_py.wrap_get_requires_for_build_wheel(f'{__file__}/../..')
run(f'sudo pip install {names}')

Expand Down Expand Up @@ -275,7 +275,7 @@ def run(command):
run(f'. {venv_name}/bin/activate && pip install --upgrade installer')
run(f'{env} {venv_name}/bin/python -m pip wheel -vv -w dist {os.path.abspath(pymupdf_dir)}')
elif pip == 'sudo':
run(f'sudo pip install --upgrade pip')
#run(f'sudo pip install --upgrade pip') # Breaks on Github see: https://github.com/pypa/get-pip/issues/226.
run(f'sudo pip install installer')
run(f'{env} pip wheel -vv -w dist {os.path.abspath(pymupdf_dir)}')
else:
Expand Down

0 comments on commit 26a8093

Please sign in to comment.