-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python 2.7 and 3.6. #736
Conversation
@dhoomakethu please have a look, I think I did it correctly, but for CI I really would like a second opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest seems to be fine :)
Kudos, SonarCloud Quality Gate passed! |
The failing 3.7 test is outside our control, it seems installing dependencies etc. takes too long. |
It smells suspicious...in other running actions it got at least to the tests and have been cancelled after ~ 8 min. |
I hate such things, where you can't traceback well ... there was a warning in the logs, but this shouldn't be the cause of the "now I want to run, now I cancel"-Action. |
And as you can see, just restarting the job did the trick, there are indeed something fishy with the 3.7 tests. |
Remove CI for 2.7 and 3.6.
Update README.rst to reflect we support python >= 3.7