Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 2.7 and 3.6. #736

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Remove python 2.7 and 3.6. #736

merged 2 commits into from
Apr 1, 2022

Conversation

janiversen
Copy link
Collaborator

Remove CI for 2.7 and 3.6.
Update README.rst to reflect we support python >= 3.7

@janiversen
Copy link
Collaborator Author

@dhoomakethu please have a look, I think I did it correctly, but for CI I really would like a second opinion.

Copy link
Collaborator

@swamper123 swamper123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest seems to be fine :)

doc/INSTALL Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@janiversen
Copy link
Collaborator Author

The failing 3.7 test is outside our control, it seems installing dependencies etc. takes too long.

@swamper123
Copy link
Collaborator

It smells suspicious...in other running actions it got at least to the tests and have been cancelled after ~ 8 min.
This time it was cancelled before the tests .... there is sth. fishy.

@swamper123
Copy link
Collaborator

I hate such things, where you can't traceback well ... there was a warning in the logs, but this shouldn't be the cause of the "now I want to run, now I cancel"-Action.
From my side this PR is fine and maybe we find the root of all macOS-Pypy-3.7 evil at some time. ^^

@janiversen
Copy link
Collaborator Author

And as you can see, just restarting the job did the trick, there are indeed something fishy with the 3.7 tests.

@janiversen janiversen merged commit 4e0792d into pymodbus-dev:dev Apr 1, 2022
@janiversen janiversen deleted the python36 branch April 1, 2022 09:49
@swamper123 swamper123 mentioned this pull request Apr 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants