Asyncio server will set serving=False if it fails to start #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asyncio server should notify that it is NOT serving if the server fails to start.
At this time, the server has no
server.start_serving()
method only aserver.serve_forever()
method. This means the only way to detect if the server is ready to receive connectionsawait server.serving()
withdefer_start=False
.This is particularly useful when using the modbus server in a unit test.
At the moment the above code would just hang and I can see no other future that will return both when the server starts and if it fails to start.
This PR then sets the
serving
toFalse
if the server fails to startup.