Endianness now used in packing bytes #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been chasing down a weird bug with some Modbus TCP devices. The holding registers read:
or
[0, 16320, 0, 16448]
. This should decode to two 32-bit floats: 1.5 and 3.0. This code:prints -2.984375 and 3.0. I found that this was due to a hardcoded bigendian in
BinaryPayloadDecoder.fromRegisters
. With that replaced with theendian
variable, everything decodes properly.