Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat exception codes as valid responses #662

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

christiansandberg
Copy link
Contributor

When an exception response is received the function code is different from the request but the frame should still be considered valid.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dhoomakethu
Copy link
Contributor

@christiansandberg I will cherry pick this to 2.5.3 branch and will close this PR.

@dhoomakethu dhoomakethu merged commit 69cfefe into pymodbus-dev:dev Oct 17, 2021
camtarn pushed a commit to camtarn/pymodbus that referenced this pull request Dec 6, 2021
camtarn added a commit to camtarn/pymodbus that referenced this pull request Dec 6, 2021
camtarn added a commit to camtarn/pymodbus that referenced this pull request Dec 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants