Closes #657 #659
Merged
Closes #657 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
@janiversen This will most probably will go to 3.0.0 release (refer #658 ) And will not be available for python < 3.7. JFYI, though there are chances I might release 2.5.3 with this fix alone depending on how much this fix is required for others. |
|
We are at python3.8 and testing 3.9 so that is not a problem. I plan to change to pymodbus 3.0 once it is a bit mature and at the same time only using asyncio. I hope you find others with the same issue, since a 2.5.3 is a fast update in homeassistant (you have 508 active installations here, that should notivqte a bit 😃 ) |
This was
linked to
issues
Aug 1, 2021
camtarn
pushed a commit
to camtarn/pymodbus
that referenced
this pull request
Dec 6, 2021
camtarn
added a commit
to camtarn/pymodbus
that referenced
this pull request
Dec 6, 2021
camtarn
added a commit
to camtarn/pymodbus
that referenced
this pull request
Dec 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #657
Use
in_waitingonly with serial clients.